chore: support extending ftltest context with additional options #2535
+125
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
jvmakine
commented
Aug 29, 2024
| @@ -25,6 +25,9 @@ import ( | |||
| mcu "github.com/TBD54566975/ftl/internal/testutils/modulecontext" | |||
| ) | |||
|
|
|||
| // Allows tests to mock module reflection | |||
| var moduleGetter = reflection.Module | |||
There was a problem hiding this comment.
We probably want to eventually figure out a more comprehensive way to stub out the reflection for tests.
jvmakine
force-pushed
the
juho/issue-2393-sub-context
branch
from
d05e148 to
c13cc96
Compare
gak
reviewed
Aug 29, 2024
gak
reviewed
Aug 29, 2024
gak
reviewed
Aug 29, 2024
gak
approved these changes
Aug 29, 2024
jvmakine
force-pushed
the
juho/issue-2393-sub-context
branch
from
c13cc96 to
2b3ef5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
SubContextfunction, that replays options from a previous fakeFTL creation, appending new options to it.Closes #2393